timohirt / terraform-provider-hetznerdns

Terraform provider for Hetzner DNS
Mozilla Public License 2.0
109 stars 21 forks source link

Consider allowing HETZNER_DNS_TOKEN as env var as well #65

Open flortsch opened 2 months ago

flortsch commented 2 months ago

Hello!

I would like to make the suggestion to also allow the env var HETZNER_DNS_TOKEN for setting the Hetzner DNS API token.

We are using Terraform together with Ansible and its Hetzner DNS community module (https://docs.ansible.com/ansible/latest/collections/community/dns/docsite/hetzner_guide.html) that uses this env var for setting the token. By using the same env var, we could only need to configure the token once.

This would also align with the Hetzner Terraform provider (https://registry.terraform.io/providers/hetznercloud/hcloud/latest/docs) and the Ansible Hetzner Cloud inventory plugin (https://docs.ansible.com/ansible/latest/collections/hetzner/hcloud/hcloud_inventory.html) or parts of the Ansible Hetzner collection in general, which all use the same env var HCLOUD_TOKEN.

What do you think?

kimdre commented 2 months ago

Hi, this provider is no longer maintained. You can open an issue or pull request for our new provider instead: https://github.com/germanbrew/terraform-provider-hetznerdns

Alternatively you could specify your api token in a .env file and use the dotenv provider.

flortsch commented 2 months ago

Hi, this provider is no longer maintained. You can open an issue or pull request for our new provider instead: https://github.com/germanbrew/terraform-provider-hetznerdns

Alternatively you could specify your api token in a .env file and use the dotenv provider.

Ah okay, didn't know that. Maybe a note in the README of this Github project would help future users. I will open an issue in the new project.

kimdre commented 2 months ago

Timo is the only one who maintains this repo, but unfortunately he no longer works on it and also doesn't respond to messages. That's the reason why we forked this repo.