search

timolins / react-hot-toast

Smoking Hot React Notifications 🔥
https://react-hot-toast.com
MIT License
9.68k stars 323 forks source link

Bug: toastOptions.duration affects toast.promise loading #132

Open philipaarseth opened 2 years ago

philipaarseth commented 2 years ago

Found what looks to be a bug: the default duration in toastOptions affect the loading part of toast.promise. So instead of it loading to infinity, it will only load for (in this case) 3000ms and then disappear, and then later on the success toast will appear.

toastOptions={{
  duration: 3000, // this affects toast.promise
}}

https://user-images.githubusercontent.com/31098164/141494858-0ba86c78-7fde-4c35-88ba-bea3eb64d11d.mov

Was testing on 2.1.0, but couldn't find anything in 2.1.1 commits pertaining to this.

sairajchouhan commented 2 years ago

Can I work on this?

devnomic commented 1 year ago

Confirmed

percy507 commented 1 year ago

Confirmed at v2.4.0