search

timolins / react-hot-toast

Smoking Hot React Notifications 🔥
https://react-hot-toast.com
MIT License
9.78k stars 331 forks source link

fix: csstype peer dep #183

Closed eeston closed 2 years ago

eeston commented 2 years ago

Small change to fix this issue.

This release contained the fix for the missing peer dependency.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-hot-toast ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 6:48PM (UTC)
timolins commented 2 years ago

Thanks a lot for the PR. Before I merge, I have to check the dev setup. For some reasons, I had troubles using a v2 lockfile, which caused the Next.js site to break.

This is long overdue so I think this is the sign to tacke it.

eeston commented 2 years ago

@timolins I believe you need to be on npm v7 or higher for the new lockfile.

In hindsight, I probably shouldn't have included that change. Would you like me to drop the commit & push a change with a v1 lockfile?

timolins commented 2 years ago

That would be great for now. I just opened an issue explaining why I've been using an old NPM version: https://github.com/timolins/react-hot-toast/issues/186

I'll do some more digging, maybe I can get it resolved.

eeston commented 2 years ago

Apologies for the delay. I dropped the commit containing the v2 lockfile changes :)

grunklejp commented 2 years ago

TY for doing this! Us clean install purists would love this merged :)