search

timols / java-gitlab-api

A wrapper for the Gitlab API written in Java
Apache License 2.0
383 stars 317 forks source link

Add possibility to use previous versions of rest api #333

Closed yaggg closed 5 years ago

timols commented 5 years ago

@yaggg thanks for submitting this! I think this is a good idea, but I wonder if this should instead be set on the instance (in the constructor, still final) instead of being mutable statically? What do you think? That way you could theoretically, if you wanted to, run multiple API versions within the same memory space.

yaggg commented 5 years ago

@timols Sure, I strongly agree that final instance variable is much better than mutable static variable, do you think I should overload connect method for passing API version?

timols commented 5 years ago

Yep, I think that makes sense.