timols / java-gitlab-api

A wrapper for the Gitlab API written in Java
Apache License 2.0
387 stars 317 forks source link

Throw UncheckedIOException instead of generic RuntimeException #339

Closed islandsvinur closed 5 years ago

islandsvinur commented 5 years ago

In issue #337 we discussed rethrowing the IOException from the API border, but since many methods nowadays don't throws IOException it would be a huge breaking change.

I therefore decided to only change the exception type from RuntimeException to UncheckedIOException to be able to distinguish between them in API consuming business logic. For consumers already catching RuntimeException to handle the wrapped IOException, nothing will change.