timols / java-gitlab-api

A wrapper for the Gitlab API written in Java
Apache License 2.0
383 stars 317 forks source link

due date deserialization fix #351

Closed durm closed 5 years ago

cowtowncoder commented 4 years ago

I am not sure how everything came together, but this is broken, as per test GitlabIssueDeserializationTest. Perhaps due to #355 or... something else.

But the issue is this: field dueDate is now of type java.util.Date; similarly setter and getter. But custom deserializer registered produces LocalDate. What is needed is to make sure they all have LocalDate AND there is also serializer registered.

It would probably be cleaner to actually register JavaTimeModule and not use annotations: this would work for all LocalDate fields.