timols / java-gitlab-api

A wrapper for the Gitlab API written in Java
Apache License 2.0
387 stars 317 forks source link

Fix getting commits for a merge request originating from a (now deleted) fork #403

Open cpfeiffer opened 2 years ago

cpfeiffer commented 2 years ago

This method used to use the merge request's source project (e.g. a fork) to get the commits. However this appears to be unnecessary and wrong with current GitLab versions at least 14.x, 15.x).

In particular, this would fail hard when trying to get the commits after the source project was deleted.

The commits of a merge request belong to the project of the merge request and not to any other project where they may have been developed in.

This now works both for fork (still available) and fork (deleted), as well as merge requests from within the same project (no fork),