search

timolson / cointrader

Coin Trader is a Java-based backend for algorithmically trading cryptocurrencies. It provides data collection and export, complex event processing and triggering, and backtesting - paper trading - live trading.
Other
453 stars 166 forks source link

exit fails #151

Closed IanWorthington closed 6 years ago

IanWorthington commented 6 years ago

Looks like this is #137 again?

ct> exit 2018-03-31 21:38:18 [main] INFO org.cryptocoinpartners.persist - initializing persistence 2018-03-31 21:38:18 [main] WARN org.cryptocoinpartners.runMode - Could not run command exit java.lang.NullPointerException: null at org.cryptocoinpartners.util.PersistUtil.createEntityManager(PersistUtil.java:698) ~[classes/:na] at org.cryptocoinpartners.util.PersistUtil.shutdown(PersistUtil.java:723) ~[classes/:na] at org.cryptocoinpartners.command.ExitCommand.call(ExitCommand.java:27) ~[classes/:na] at org.cryptocoinpartners.bin.ConsoleRunMode.run(ConsoleRunMode.java:92) ~[classes/:na] at org.cryptocoinpartners.bin.Main.main(Main.java:133) [classes/:na] Internal error: see cointrader.log

douggie commented 6 years ago

hi ian,

the commands are really for testing so probably a few areas they need tidying up will take a look.

On Sun, 1 Apr 2018, 03:42 IanWorthington, notifications@github.com wrote:

ct> exit 2018-03-31 21:38:18 [main] INFO org.cryptocoinpartners.persist - initializing persistence 2018-03-31 21:38:18 [main] WARN org.cryptocoinpartners.runMode - Could not run command exit java.lang.NullPointerException: null at org.cryptocoinpartners.util.PersistUtil.createEntityManager(PersistUtil.java:698) ~[classes/:na] at org.cryptocoinpartners.util.PersistUtil.shutdown(PersistUtil.java:723) ~[classes/:na] at org.cryptocoinpartners.command.ExitCommand.call(ExitCommand.java:27) ~[classes/:na] at org.cryptocoinpartners.bin.ConsoleRunMode.run(ConsoleRunMode.java:92) ~[classes/:na] at org.cryptocoinpartners.bin.Main.main(Main.java:133) [classes/:na] Internal error: see cointrader.log

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/timolson/cointrader/issues/151, or mute the thread https://github.com/notifications/unsubscribe-auth/AENHahn73zGHB1ibH2pqa1NA-21p_Zy_ks5tkD6KgaJpZM4TCr-V .

IanWorthington commented 6 years ago

Don't think exit is a biggie, but the commands as whole are the first thing newbies like me will try so it's important that they more-or-less work as installation verification.

douggie commented 6 years ago

totally agree.

On Sun, Apr 1, 2018 at 6:54 PM, IanWorthington notifications@github.com wrote:

Don't think exit is a biggie, but the commands as whole are the first thing newbies like me will try so it's important that they more-or-less work as installation verification.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/timolson/cointrader/issues/151#issuecomment-377804526, or mute the thread https://github.com/notifications/unsubscribe-auth/AENHan2Oj5ML6q3szTLW2hlXDgxGscaKks5tkRRfgaJpZM4TCr-V .

IanWorthington commented 6 years ago

Added a PR to ensure that exit always exits, regardless of anything that happens.