timomeh / react-native-material-bottom-navigation

๐Ÿ’…๐Ÿ”ง๐Ÿ‘Œ a beautiful, customizable and easy-to-use material design bottom navigation for react-native
MIT License
710 stars 127 forks source link

this.handleDimensionChange.removeListener is undefined #143

Open AhsanSheikh02 opened 1 year ago

AhsanSheikh02 commented 1 year ago

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch react-native-material-bottom-navigation@1.0.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js b/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
index 08ac9cd..6b29bd1 100644
--- a/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
+++ b/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
@@ -108,9 +108,9 @@ export default class BottomNavigation extends React.Component {
     }
   }

-  componentWillUnmount() {
-    Dimensions.removeEventListener('change', this.handleDimensionChange)
-  }
+  // componentWillUnmount() {
+  //   Dimensions.removeEventListener('change', this.handleDimensionChange)
+  // }

   handleDimensionChange = () => {
     if (Device.isLandscape() && !this.state.isLandscape) {

This issue body was partially generated by patch-package.