search

timomeh / react-native-material-bottom-navigation

💅🔧👌 a beautiful, customizable and easy-to-use material design bottom navigation for react-native
MIT License
710 stars 127 forks source link

fix shifting can't set to false #56

Closed damathryx closed 7 years ago

damathryx commented 7 years ago

When I set shifting props to false it doesn’t take effect. The tabs are still shifting.

damathryx commented 7 years ago

sorry, seems this is not a solution.

MingweiSamuel commented 6 years ago

for reference, the correct way to do this is by passing in shifting={false} (shifting=false is wrong syntactically, and shifting="false" is interpreted as a non-empty string, which is truthy. You could also do shifting="" which is falsy...)

timomeh commented 6 years ago

@MingweiSamuel You're right, the current BottomNavigation is full of sins. Will be fixed with #76