search

timomeh / react-native-material-bottom-navigation

💅🔧👌 a beautiful, customizable and easy-to-use material design bottom navigation for react-native
MIT License
709 stars 127 forks source link

badge support #70

Closed ShayanJavadi closed 6 years ago

ShayanJavadi commented 6 years ago

Added badge support. This also adds react-native-material-ui as a dependency.

screen shot 2018-02-04 at 2 22 45 am

https://github.com/timomeh/react-native-material-bottom-navigation/issues/52

timomeh commented 6 years ago

Thank you for your PR. While I don't have anything against dependencies, react-native-material-ui is quite a big dependency just to use their Badge.

Implementing a Badge without react-native-material-ui wouldn't be that hard, I think.

I would accept this PR without react-native-material-ui, but at the current state I can't justify shipping this with such a big dependency for one feature.

ShayanJavadi commented 6 years ago

That makes sense. I will update the pr by implementing a badge and removing the dependency then. Stay tuned.

ShayanJavadi commented 6 years ago

@timomeh I've update the pr, implemented the Badge component, and updated the documentation to reflect the changes. Please review my changes and let me know if you have any feedback.

Here's screenshots of the badge:

screen shot 2018-02-07 at 1 06 42 am screen shot 2018-02-07 at 1 06 47 am
ShayanJavadi commented 6 years ago

@timomeh You're welcome! Thank you for making this library! I will implement/test your requested changes and will update the pr soon (thanks for figuring out the android compatibility issues!).

ShayanJavadi commented 6 years ago

@timomeh PR has been updated with the requested changes. Here's screenshots from both iOS and Android:

screen shot 2018-02-11 at 2 30 29 am screen shot 2018-02-11 at 2 30 35 am
timomeh commented 6 years ago

Looks good to me! I'm going to merge it and make a now release.