Fixed badge animation - Githubissues

timomeh / react-native-material-bottom-navigation

💅🔧👌 a beautiful, customizable and easy-to-use material design bottom navigation for react-native

MIT License

710 stars 127 forks source link

Fixed badge animation #71

Closed ShayanJavadi closed 6 years ago

ShayanJavadi commented 6 years ago

In my last pr I forgot that moving the renderBadge() method out of the renderIcon() method will cause it to lose the animation when you press on the tab. In this pr I've fixed that. the animation is now working properly for the badge

timomeh commented 6 years ago

Nice catch! Since I originally didn't test it in iOS, I didn't saw that there's an animation. Thank you

timomeh commented 6 years ago

Thank you! 🎉

Going to merge it and do a patch release right now.