timomeinen / team-piazza

A build monitor for the TeamCity continuous integration server
GNU General Public License v3.0
17 stars 7 forks source link

Read user from commit metadata, and show it in the output #36

Closed timomeinen closed 10 years ago

timomeinen commented 10 years ago

From gro...@gmail.com on October 14, 2010 07:33:09

Currently the user is only read from the commit messages, as per the documentation at http://code.google.com/p/team-piazza/wiki/ConfiguringTeamPortraits .

Requiring the user to add their username is hard to enforce, and (IMHO) seems like something that a tool like Team Piazza should be dictating. The user that checked in the change is already part of the commit metadata, Team Piazza should pick that up -- and optionally also parse usernames from the commit message to retain existing functionality.

This way multiple additional workflows are allowed:

In addition to the currently-expected methods by team piazza:

The userid from the commit message should be displayed before the commit message itself, eg:

(greg) Did a change to some code

Original issue: http://code.google.com/p/team-piazza/issues/detail?id=36

timomeinen commented 10 years ago

From gro...@gmail.com on April 08, 2011 06:32:54

Just revisiting, apparently this does work, so long as names are configured in main-config.xml.

timomeinen commented 10 years ago

From timomeinen on November 29, 2011 07:12:33

Piazza checks commit message and commit metadata - especially author name.

Status: Fixed
Labels: -Type-Defect Type-Enhancement