timomeinen / team-piazza

A build monitor for the TeamCity continuous integration server
GNU General Public License v3.0
17 stars 7 forks source link

Cannot see user pictures #62

Closed CiCdDeveloper closed 4 years ago

CiCdDeveloper commented 6 years ago

I am using TeamCity Enterprise 2017.2 (build 50574) with TeamPiazza version snapshot-20151022091909. In Team Piazza Build Monitor, it is not displaying the picture of the user who has last commited the change up on build failure. I have tried both using image from Gravatar.com as well as an explicit url to image.

However, if I uncheck "Show user pictures only on build failure", then I see pictures all TeamCity users. In my case the build of code has actually succeeded, however, the automation tests failed. I would like the image of the user who last committed the change to be shown. My question is can TeamPiazza recognize the failure of whole project?

timomeinen commented 6 years ago

That is the intended behaviour of Team Piazza. If you cannot see images on a build failure, most probably the VCS name does not correspond to the TeamCity user. Please check, that the Version Control username settings are configured to match the name of the developer in the commit. This is described here.

If this doesn't help, please let me know.

CiCdDeveloper commented 6 years ago

Hi Thanks for the response. My query is altogether different, may be I didn't describe correctly in first place. There is no issue with seeing images on a build failure. My question is what constitues a "build failure". What sort of failures does TeamPiazza treat as "Build Failure" and show images of last committed users accordingly? Our Continuous Integration pipeline on Teamcity consists of following build steps Step 1: Build the .NET source code using MSBuild Step 2: Deploy the solution onto one of test environments using Octopus Step3: Run Automation Tests

What I observed was, TeamPiaza treats step 1 failure only as Build failure. If Step1, Step2 passed and Step 3 failed due to some failing tests, then it still considers what whole build is successful and doesn't display the image. What I want here is the tool should consider failure of any step in the whole TeamCity project.

Hope this clarifies the issue

thanks and best regards

On 6 February 2018 at 11:25, Timo Meinen notifications@github.com wrote:

That is the intended behaviour of Team Piazza. If you cannot see images on a build failure, most probably the VCS name does not correspond to the TeamCity user. Please check, that the Version Control username settings are configured to match the name of the developer in the commit. This is described here https://github.com/timomeinen/team-piazza/wiki/Configuring-Team-Portraits .

If this doesn't help, please let me know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timomeinen/team-piazza/issues/62#issuecomment-363393836, or mute the thread https://github.com/notifications/unsubscribe-auth/AiVcO4LqOcmhhClrgE70YAjwzIzNVqzWks5tSDafgaJpZM4R0Gkg .

--

This message may contain information from Paymentsense Ltd which is confidential or privileged. If you are not the intended recipient, please advise the sender immediately by reply email and delete this message and any attachments without retaining a copy. Any views expressed in this message are those of the individual sender, except where the sender specifies and with authority.

timomeinen commented 6 years ago

I understand, that you want to have a view of your project (pipeline) with all three steps included. And as soon as a single step fails, the whole project should be "red". Correct?

I think you can do this quite now with Piazza: You have two different links to Piazza. One for the whole Project and one for a single build configuration. This is stated in the documentation: "Go to a project page to see all build configurations in the monitor or choose a single build configuration and click on the 'Team Piazza Build Monitor' link".

Does this fit your needs or do you need a dedicated view for the build chain?