search

timor / spacemacsOS

EXWM Layer to turn spacemacs into a full-fledged window manager
93 stars 11 forks source link

wrong type argument commandp #5

Closed demokritos closed 4 years ago

demokritos commented 5 years ago

https://github.com/timor/spacemacsOS/blob/ece8ffb60e51c677e76f2ffe2fc6b83b51bb1760/funcs.el#L16

This code results in error 'wrong type argument commandp' since exwm-input--grab-keyboard is not an interactive function. I think it should be replaced with exwm-input-grab-keyboard.

timor commented 5 years ago

While I agree that the code should fail, for some reason I don't trigger that error.

Can you provide reproduction steps and maybe a backtrace?

demokritos commented 5 years ago

This layer doesn't fail. Just when I call this function other places, I get this error. I am sorry I didn't seem to be clear.

timor commented 5 years ago

For some reason that code path does not seem to be traversed at the moment, although the advice in which it is used is actually created.