search

timotejroiko / discord.js-light

All the power of discord.js, zero caching. This library modifies discord.js's internal classes and functions in order to give you full control over its caching behaviour.
Apache License 2.0
292 stars 29 forks source link

TextChannel can never be an instance of User #11

Closed NotSugden closed 4 years ago

NotSugden commented 4 years ago

https://github.com/timotejroiko/discord.js-light/blob/c0abe51ac8d70065cda3e2ff208ab74f3ee09008/classes.js#L283-L285

if (this instanceof Discord.User)

but as you can see

class TextChannel extends T

where T is TextChannel from discord.js

timotejroiko commented 4 years ago

Thanks, i was still thinking in terms of TextBasedChannel. But since TextBasedChannel is not an extensible structure and is also implemented in NewsChannel i'll need to move it to init.js to avoid having to extend both.

timotejroiko commented 4 years ago

corrected in c292c7c

timotejroiko commented 4 years ago

closing this for now, let me know if there's anything else :) Thanks again!