search

timothee-haudebourg / cc-traits

Apache License 2.0
11 stars 8 forks source link

Crate requires nightly #5

Open porky11 opened 2 years ago

porky11 commented 2 years ago

I can't use this crate without nightly. The documentation only states, nightly is required for some features.

Error message:

error[E0554]: `#![feature]` may not be used on the stable release channel
   --> /home/p11/.cargo/registry/src/github.com-1ecc6299db9ec823/cc-traits-0.8.1/src/lib.rs:107:1
    |
107 | #![feature(generic_associated_types)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0554`.
error: could not compile `cc-traits` due to previous error
DCNick3 commented 2 years ago

It seems that the gat usage was added in #1 thinking that they were going to get stabilized soon (if only...).

@timothee-haudebourg promised not to release it before the GATs are stabilized, but it seems that the nightly feature was enabled in 0.5.0 release with only tagged release without GATs being 0.4.0.

The GAT-using PR was merged to a separate branch but later the gat branch was merged into master in https://github.com/timothee-haudebourg/cc-traits/commit/247c23a6b26eb996e176fcbc250d6837e01c208d

Using version 0.4.0 might allow you to not depend on nightly, but I am not sure how feature-complete that version is

timothee-haudebourg commented 2 years ago

@timothee-haudebourg promised not to release it before the GATs are stabilized

I don't remember promising anything. It is true that starting from 0.5 this crate is no longer compatible with stable Rust anymore because of GATs. Those should be shipped with Rust 1.65 at which point I'll release a version without unstable features.