search

timotheecour / Nim

Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).
http://nim-lang.org/
Other
2 stars 0 forks source link

misc TODO #121

Open timotheecour opened 4 years ago

timotheecour commented 4 years ago
timotheecour commented 4 years ago
timotheecour commented 4 years ago

revive [TODO] unittest: add optional msg to check, require by timotheecour · Pull Request #10558 · nim-lang/Nim

eg use case: see https://github.com/nim-lang/Nim/pull/14102/files, see this comment for justification: https://github.com/nim-lang/Nim/pull/14102#discussion_r414332876

timotheecour commented 4 years ago

mv changelog, see https://github.com/nim-lang/Nim/pull/14098#issuecomment-619028912

timotheecour commented 4 years ago
timotheecour commented 4 years ago

Edited: They are already quoted https://github.com/nim-lang/Nim/pull/14992/files

timotheecour commented 4 years ago

redo profiling after specialize genericReset by Araq · Pull Request #14398 · nim-lang/Nim

timotheecour commented 4 years ago

check whether NRVO suppression impacts performance fixes #14126 [backport:1.2] by Araq · Pull Request #14390 · nim-lang/Nim

timotheecour commented 4 years ago

do TODO from fix #14404 foldr had the classic multiple evaluation bug by timotheecour · Pull Request #14413 · nim-lang/Nim

timotheecour commented 4 years ago

TODO leftover from no more code duplication bw liMessage and rawMessage + several bug fixes by timotheecour · Pull Request #14415 · nim-lang/Nim

I encountered other bugs while fixing this but best to keep this one as mostly refactoring, next one will fix bugs I've encountered (at least they'll only need to be fixed in 1 place)

timotheecour commented 4 years ago

https://github.com/nim-lang/Nim/pull/16151/commits/70c289c46121a5182a34261177baffb8909584d6 testament/testament.nim

revert formatting change Expected: {..} Gotten{..} from this PR

    else:
      maybeStyledEcho fgYellow, "Expected:"
      maybeStyledEcho styleBright, "{", expected, "}\n"
      maybeStyledEcho fgYellow, "Gotten:"
      maybeStyledEcho styleBright, "{", given, "}\n"
timotheecour commented 4 years ago

document gotcha https://github.com/nim-lang/Nim/pull/16182#issuecomment-735646532

indeed. also noticed in https://github.com/nim-lang/Nim/pull/13448. It's so bad that newSeqOfCap should come with a performance warning in its doc comment explaining the newSeqOfCap(n) + seq.add(elem) anti-pattern. This isn't specific to nim.

juancarlospaco commented 3 years ago