search

timotheeg / nestrischamps

A web-based OCR and restreamer system for NES Classic Tetris players
MIT License
45 stars 11 forks source link

Make replays work on no-curtain roms #108

Closed timotheeg closed 10 months ago

timotheeg commented 2 years ago

Replays are broken on no-curtain roms atm for some reason.

Expected: they should work

timotheeg commented 2 years ago

Static code inspection looks like no-curtain roms should. On the OCR front, the sanitizer increases gameid when a new game is started, and that is based on detecting 1) getting our of game (menus, launch screen etc when either of liens, score, level is null); and then 2) having the first frame when back in game seeing score and lines at 0)

On the server, the current game is ended when a new gameid is received.

timotheeg commented 10 months ago

I don't think that's a valid issue. I'm closing and will reopen if someone complains