timotheeg / nestrischamps

A web-based OCR and restreamer system for NES Classic Tetris players
MIT License
48 stars 12 forks source link

Fix css borders #130

Closed timotheeg closed 2 years ago

timotheeg commented 2 years ago

NTC had been using the CSS box model wrong, placing the box borders in the padding area, instead of using an actual border.

This is inconsequential in term of rendering, but I realized it because I wasn't able to create a box with a transparent center when omitting the fill keyword in the border-image-slice property.

This PR updates ALL NTC layouts to use the border definition properly.

Being able to distinguish the border from the padding also allowed me to remove an unnecessary parameter field_real_border, since the information could now be found from the padding itself.