search

timotheeg / nestrischamps

A web-based OCR and restreamer system for NES Classic Tetris players
MIT License
45 stars 11 forks source link

New iberiaqual layout #147

Closed TheRealTomelloSoulMan closed 1 year ago

TheRealTomelloSoulMan commented 1 year ago

New iberiaqual layout plus some border PNGs :smiley:

timotheeg commented 1 year ago

Thanks @TheRealTomelloSoulMan ! I see you had started your branch from a main:HEAD that I discarded by hard-pushing. My apologies for the mess.

Because of that the PR not quite right for the addition of a layout. I could clean it up myself, but I'd rather your contribution is well reflected in the repo :)

So to be abled to merge, could you please do the following:

  1. update your branch TheRealTomelloSoulMan:ctwciberia to a. hard reset to nestrischamps:main b. add a single commit with the files for your new layout:
    • public/views/border_3px_iberia.png
    • public/views/border_3px_iberia2.png
    • public/views/mp/iberiaqual.html
    • public/views/mp/iberiaqual.json
  2. run the 2 pngs through pngout to optimize them and reduce their size
  3. Add a screenshot for the layout public/views/mp/iberiaqual.jpg. The screenshot should have size 1280x720

Thanks!

TheRealTomelloSoulMan commented 1 year ago

Hi Tim! Thanks for the warning. I've done what you said and hope it goes well now... I had to modify .gitignore to exclude two directories: the logs one (created it following your tutorial because I wanted NTC to run as a service) and docker/postgresql/pgdata because there's where my docker image database resides (just for testing). Please tell me if this prevents the PR being successful

El vie, 21 jul 2023 a las 10:05, Timothee Groleau @.***>) escribió:

Thanks @TheRealTomelloSoulMan https://github.com/TheRealTomelloSoulMan ! I see you had started your branch from a main:HEAD that I discarded by hard-pushing. My apologies for the mess.

Because of that the PR not quite right for the addition of a layout. I could clean it up myself, but I'd rather your contribution is well reflected in the repo :)

So to be abled to merge, could you please do the following:

  1. update your branch TheRealTomelloSoulMan:ctwciberia to a. hard reset to nestrischamps:main b. add a single commit with the files for your new layout:
    • public/views/border_3px_iberia.png
    • public/views/border_3px_iberia2.png
    • public/views/mp/iberiaqual.html
    • public/views/mp/iberiaqual.json
  2. run the 2 pngs through pngout https://en.wikipedia.org/wiki/PNGOUT to optimize them and reduce their size
  3. Add a screenshot for the layout public/views/mp/iberiaqual.jpg. The screenshot should have size 1280x720

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/timotheeg/nestrischamps/pull/147#issuecomment-1645178959, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATQRRMLZ2CG66SX2II5BBTDXRIZ3LANCNFSM6AAAAAA2R3XSSE . You are receiving this because you were mentioned.Message ID: @.***>