Closed TheRealTomelloSoulMan closed 1 year ago
The DD_RUM stuff is no longer needed, I'll remove that after I merge.
@TheRealTomelloSoulMan FYI I've pushed a commit to make some minor amendments: https://github.com/timotheeg/nestrischamps/commit/1a006afac1a89fcca74987f4090f397a1d8d6d79
Some things to note:
The curtain and avatar pic were eating into the field border, so I fixed that. The issue for that is that there's an implicit coupling between the fact the border size by default contains a padding the same size as the pixel_size (3px). In your case, your pixel size is 4.27. so we have to be explicit about the padding, by setting the --border-size
to 12px and setting the padding to 3px;
You don't need to specify the position:absolute
directive, if the rule is already supplied by the box class.
There were some minor misalignments for lns
and score
, so I shifted some things by 1px here and there. Pixel perfection all the way! :D
Thanks for contributing a layout to NestrisChamps! ๐ ๐
Nice! Thanks for fixing those things. I noticed the avatar issue but forgot to fix it before the PR, just because I deleted my avatar URL ๐. Gonna fetch main from you right now
El sรกb, 22 jul 2023 a las 8:15, Timothee Groleau @.***>) escribiรณ:
@TheRealTomelloSoulMan https://github.com/TheRealTomelloSoulMan FYI I've pushed a commit to make some minor amendments: 1a006af https://github.com/timotheeg/nestrischamps/commit/1a006afac1a89fcca74987f4090f397a1d8d6d79
Some things to note:
-
The curtain and avatar pic were eating into the field border, so I fixed that. The issue for that is that there's an implicit coupling between the fact the border size by default contains a padding the same size as the pixel_size (3px). In your case, your pixel size is 4.27. so we have to be explicit about the padding, by setting the --border-size to 12px and setting the padding to 3px;
You don't need to specify the position:absolute directive, if the rule is already supplied by the box class.
There were some minor misalignments for lns and score, so I shifted some things by 1px here and there. Pixel perfection all the way! :D
Thanks for contributing a layout to NestrisChamps! ๐ ๐
โ Reply to this email directly, view it on GitHub https://github.com/timotheeg/nestrischamps/pull/148#issuecomment-1646501341, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATQRRMIQSXU3ONEAXGC2ARTXRNVZNANCNFSM6AAAAAA2TDSZMY . You are receiving this because you were mentioned.Message ID: @.***>
Here's my new PR for the iberiaqual layout, hope it all goes fine this time :smile: