search

timotheeg / nestrischamps

A web-based OCR and restreamer system for NES Classic Tetris players
MIT License
48 stars 12 forks source link

Add plus/minus indicator on score and tetris lead metrics #153

Closed timotheeg closed 11 months ago

timotheeg commented 11 months ago

NTC doesn't have a plus/minus indicator because the assumption was that it is redundant to the lead color (green/red).

It was brought to my attention that color indicator only is not great for color blind people, and the plus/minus indicator has value and should be added to NTC.

An additional consideration for dropping the plus/minus indicator is that it adds one extra characters which can mess up the display when width is tight. Solution to that: under the assumption that layouts supports 7 characters scores, add a plus/minus indicator only if the diff is less than 1M.

TODO: figure out width consideration for the tetris lead (currently tetris lead is always displayed at 4 characters)

timotheeg commented 11 months ago

Implemented with https://github.com/timotheeg/nestrischamps/commit/0c17c2e92317689e150b93f8a04269e2d7fff92a

If any comp is having issues with the indicator, it can be turned off by adding to the player options:

plus_minus_lead_indicator: false