search

timotheeg / nestrischamps

A web-based OCR and restreamer system for NES Classic Tetris players
MIT License
48 stars 12 forks source link

Added prettier config and applied to all files. #75

Closed EamonHeffernan closed 3 years ago

EamonHeffernan commented 3 years ago

Not nessesary change. Personal preference if you want to use prettier or keep manual formatting.

alex-ong commented 3 years ago

Are you using an automated tool for this? By automated i mean literally running one command.

In python land there is black . and pylint. Are you using an equivalent? Prettifiying the code is important, it is much cleaner. But moving forward it needs to be automated; so i suggest rolling that functionality into this PR.

EamonHeffernan commented 3 years ago

I reformatted all the files and added a config file using "prettier" https://prettier.io/, which formats based on the configuration on a per project level. Anyone who installs and sets up prettier will automatically follow the rules layed out in the config file.

alex-ong commented 3 years ago

I suggest adding documentation for installing prettier as a precommit hook then; this could be inside developerment.md or readme.md