Finding API example no longer works

BreD1810 commented 4 years ago

I tried the example code:

from ebaysdk.finding import Connection as Finding
from ebaysdk.exception import ConnectionError

try:
    api = Finding(config_file='myfile.yaml')
    response = api.execute('findItemsAdvanced', {'keywords': 'Python'})
    print(response.dict())
except ConnectionError as e:
    print(e)
    print(e.response.dict())

I got the result: ConnectionResetError: [Errno 104] Connection reset by peer

The current fix is to change to:

api = Finding(config_file='myfile.yaml', https=True)

Related eBay blog post here.

timotheus commented 4 years ago

Thanks. I'll update.

On Thu, Apr 16, 2020 at 5:40 AM Bradley Garrod notifications@github.com wrote:

I tried the example code:

from ebaysdk.finding import Connection as Findingfrom ebaysdk.exception import ConnectionError try: api = Finding(config_file='myfile.yaml') response = api.execute('findItemsAdvanced', {'keywords': 'Python'}) print(response.dict())except ConnectionError as e: print(e) print(e.response.dict())

I got the result: ConnectionResetError: [Errno 104] Connection reset by peer

The current fix is to change to:

api = Finding(config_file='myfile.yaml', https=True)

Related eBay blog post here https://developer.ebay.com/news/https-only-finding-api/.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/timotheus/ebaysdk-python/issues/307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2QX4QUF3NLKDNR56I6BDRM34DVANCNFSM4MJTVASQ .

timotheus commented 4 years ago

After further review, https is set as the default. You shouldn't need to override this in the constructor unless it's somehow being set to false in your config file.

What version of the sdk are you using?

On Thu, Apr 16, 2020 at 7:38 AM Tim Keefer tkeefer@gmail.com wrote:

Thanks. I'll update.

On Thu, Apr 16, 2020 at 5:40 AM Bradley Garrod notifications@github.com wrote:

I tried the example code:

from ebaysdk.finding import Connection as Findingfrom ebaysdk.exception import ConnectionError try: api = Finding(config_file='myfile.yaml') response = api.execute('findItemsAdvanced', {'keywords': 'Python'}) print(response.dict())except ConnectionError as e: print(e) print(e.response.dict())

I got the result: ConnectionResetError: [Errno 104] Connection reset by peer

The current fix is to change to:

api = Finding(config_file='myfile.yaml', https=True)

Related eBay blog post here https://developer.ebay.com/news/https-only-finding-api/.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/timotheus/ebaysdk-python/issues/307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2QX4QUF3NLKDNR56I6BDRM34DVANCNFSM4MJTVASQ .

BreD1810 commented 4 years ago

My current version of the sdk is 2.1.5, with Python 3.8.2

My YAML config matches the sample config file provided.

fsmosca commented 4 years ago

@timotheus

sdk 2.1.5, Finding, https, False  
current repo code, Finding, https, True

Perhaps time to make an official release.

timotheus commented 4 years ago

Yes, I will release this week.

On Sun, Apr 19, 2020 at 11:02 PM fsmosca notifications@github.com wrote:

@timotheus https://github.com/timotheus

sdk 2.1.5, Finding, https, False current repo code, Finding, https, True

Perhaps time to make an official release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timotheus/ebaysdk-python/issues/307#issuecomment-616329720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2QXZUE26PCSE7YLNVN3LRNPQQLANCNFSM4MJTVASQ .

timotheus commented 4 years ago

fyi, just released 2.2.0 to pypi

On Mon, Apr 20, 2020 at 8:35 AM Tim Keefer tkeefer@gmail.com wrote:

Yes, I will release this week.

On Sun, Apr 19, 2020 at 11:02 PM fsmosca notifications@github.com wrote:

@timotheus https://github.com/timotheus

sdk 2.1.5, Finding, https, False current repo code, Finding, https, True

Perhaps time to make an official release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timotheus/ebaysdk-python/issues/307#issuecomment-616329720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2QXZUE26PCSE7YLNVN3LRNPQQLANCNFSM4MJTVASQ .

BreD1810 commented 4 years ago

Working great now, thanks!

timotheus / ebaysdk-python

Finding API example no longer works #307