timothy-barry / ondisc

Space- and time-optimal algorithms for large single-cell expression matrices, with a focus on single-cell CRISPR screens.
https://timothy-barry.github.io/ondisc/
Other
11 stars 5 forks source link

Input format for create_ondisc_matrix_from_R_matrix() #18

Closed ekatsevi closed 2 years ago

ekatsevi commented 2 years ago

I tried passing a sparse matrix in dgCMatrix format to create_ondisc_matrix_from_R_matrix(), but it said that the input is required to be in dgRMatrix format (or perhaps it could also be in dense format). Could you please add support for dgCMatrix input?

ekatsevi commented 2 years ago

Here is the error message I got when trying to input a dgCMatrix:

image

timothy-barry commented 2 years ago

Thanks. Issue resolved with commit https://github.com/timothy-barry/ondisc/commit/191c324234be3fa1f5316cf26800d697970b7ba0.