timothy-barry / ondisc

Space- and time-optimal algorithms for large single-cell expression matrices, with a focus on single-cell CRISPR screens.
https://timothy-barry.github.io/ondisc/
Other
11 stars 5 forks source link

Some tweaks #2

Closed yixuan closed 3 years ago

yixuan commented 3 years ago

This PR provides some tweaks and bug fixes to existing code. For example,

  1. Use system-independent functions dirname() and file.path() to replace regular expressions.
  2. Use the pattern argument in list.files().
  3. Correctly escape the "." character in regular expressions. To match the ".h5" suffix, we need to use "\\.h5$", not ".h5$".
timothy-barry commented 3 years ago

Thanks, looks good!