timothyas / xesn

Large scale Echo State Networks powered by xarray and dask.
https://xesn.readthedocs.io
Apache License 2.0
1 stars 1 forks source link

[joss] Add missing DOI #79

Closed sneakers-the-rat closed 3 weeks ago

sneakers-the-rat commented 4 weeks ago

Part of: https://github.com/openjournals/joss-reviews/issues/7286

Is https://doi.org/10.1017/cbo9780511617652.004 the same as the Lorenz 1996 paper you are citing, or is that a different work? Just want to check to satisfy our very picky DOI checker, close this if those are two different citations.

sneakers-the-rat commented 4 weeks ago

I think this is the citation for dask

@InProceedings{ matthew_rocklin-proc-scipy-2015,
  author    = { {M}atthew {R}ocklin },
  title     = { {D}ask: {P}arallel {C}omputation with {B}locked algorithms and {T}ask {S}cheduling },
  booktitle = { {P}roceedings of the 14th {P}ython in {S}cience {C}onference },
  pages     = { 126 - 132 },
  year      = { 2015 },
  editor    = { {K}athryn {H}uff and {J}ames {B}ergstra },
  doi       = { 10.25080/Majora-7b98e3ed-013 }
}
timothyas commented 4 weeks ago

Thanks for these @sneakers-the-rat

sneakers-the-rat commented 4 weeks ago

I don't think it's correct.

Got it! you know better than me.

I don't see that anymore

odd... well when in doubt you can double-cite: citations are free to make and costly (to the cited authors) to miss. neutral on this change, either/or works for me.

feel free to close this once you merge #80

timothyas commented 3 weeks ago

Strong agree: it's easy to cite, but is a shame not to be appropriately cited. I added both dask citations in the text.