search

timothyasp / nova-color-field

Simple Laravel Nova Color Picker Field
76 stars 21 forks source link

Nova 4 Support: We get the following incompatible interface implementation error #20

Open hasnat-we opened 1 year ago

hasnat-we commented 1 year ago

Declaration of Timothyasp\Color\Color::compact() must be compatible with Laravel\Nova\Fields\Field::compact(bool $compact = true)

jangaraev commented 1 month ago

the same to me. could add some context and details here:

Laravel: v11.24.1
Nova: v4.35.1

    "message": "Declaration of Timothyasp\\Color\\Color::compact() must be compatible with Laravel\\Nova\\Fields\\Field::compact(bool $compact = true)",
    "exception": "Symfony\\Component\\ErrorHandler\\Error\\FatalError",
    "file": "...\\vendor\\timothyasp\\nova-color-field\\src\\Color.php",
    "line": 37,
    "trace": []

this happens for the following request:

image

jangaraev commented 1 month ago

I tried to prepare a PR for that, but see that the fix has already been applied in the source code.

https://github.com/timothyasp/nova-color-field/commit/436bca05c2a5cc791cc7645eecb519cca0bcaf89

@timothyasp is there a chance to release the patch version?

would be very much appreciated 👍

jangaraev commented 1 month ago

found out that for some reason I used the outdated version of the package.

sorry for bothering 🤯