timothybrooks / hdr-plus

HDR+ Implementation
MIT License
601 stars 203 forks source link

Move to CMake #5

Closed lamerman closed 6 years ago

lamerman commented 6 years ago

3

lamerman commented 6 years ago

As I understand the CUDA_PATH variable is not used currently.

In general it is supposed to work like this:

  1. Change HALIDE_ROOT_DIR in CMakeLists.txt to yours.
  2. mkdir build; cd build
  3. cmake ..
  4. make
lamerman commented 6 years ago

About HALIDE_ROOT_DIR, the other option would be to specify it in command line, not in CMakeLists.txt, like this cmake -DHALIDE_ROOT_DIR="/home/lamerman/work/hdr/halide/" ..

but probably it will be more complicated for people, so I left it as it was before.

timothybrooks commented 6 years ago

Great, thank you for adding this improvement! I think keeping HALIDE_ROOT_DIR in CMakeLists.txt, like you currently have, is best. I will update the README to explain the simple compilation procedure.