timothybrooks / hdr-plus

HDR+ Implementation
MIT License
594 stars 201 forks source link

Wrong Halide Release #53

Closed gcilli closed 4 years ago

gcilli commented 4 years ago

In the README.md file, it is specified to download the "2017-06-03" release of Halide. However, according to the historical release link, such release does not exists. The closest ones are:

Which release should be downloaded?

Thank you.

brotherofken commented 4 years ago

I tried the latest Halide's release and it worked fine. The master branch should work too.

Titaniumtown commented 4 years ago

Yea, the reason I put that was because it kept failing to compile. Then on the historical release link, they deleted the "2017-06-03" release, I have no idea why. I will update the read me if I can compile hdr-plus on the latest version of halide.

Titaniumtown commented 4 years ago

I have changed the readme to reflect this, issue should be solved. Thanks for bringing this to my attention!

gcilli commented 4 years ago

Thank you for the quick response.

The latest Halide's release requires llvm 7.0 or greater. Which version of llvm did you use?

gcilli commented 4 years ago

I downloaded llvm 9.0 and everything compiled.