search

timothybrooks / hdr-plus

HDR+ Implementation
MIT License
594 stars 201 forks source link

(WIP) fixes workflow and adds some stuff #64

Closed Titaniumtown closed 4 years ago

Titaniumtown commented 4 years ago

btw, i'm sorry there is so many commits, lol. I was figuring out how to use github actions.

What this PR does:

What needs to be fixed:

Things that could be implemented:

Titaniumtown commented 4 years ago

oh btw the checks will probably fail atm bc I got to fix some more stuff.

Titaniumtown commented 4 years ago

@brotherofken do you have any suggestions? I believe you have more experience at this than me.

brotherofken commented 4 years ago

Looks good to me. Became a bit complicated though. Do you think that anyone will try to run this on a 32-bit arch and especially arm32? :-)

Titaniumtown commented 4 years ago

No, but it doesn't really hurt to have it. And in the rare case someone will try to compile on a 32-bit system, it'll be useful.

Titaniumtown commented 4 years ago

@brotherofken , see the issue i'm having: https://github.com/timothybrooks/hdr-plus/actions/runs/99488199

Titaniumtown commented 4 years ago

Did I do something wrong?

Titaniumtown commented 4 years ago

I think I found the issue...

Titaniumtown commented 4 years ago

wait no I haven't, I still need help. lol

Titaniumtown commented 4 years ago

oh! it seemed like it built! https://github.com/Titaniumtown/hdr-plus/runs/657698910?check_suite_focus=true

Titaniumtown commented 4 years ago

So I do know what I'm doing.

Titaniumtown commented 4 years ago

@brotherofken does everything look good to you? I need to be 100% sure before I merge.

brotherofken commented 4 years ago

Regarding the last failure. Could you check if this project has enough free storage?

It should be somewhere in settings -> billing -> storage.

Titaniumtown commented 4 years ago

I don't think I have access to that. Correct me if I'm wrong.

Titaniumtown commented 4 years ago

I just removed the part about updating the packages.