search

timothycrosley / portray

Your Project with Great Documentation.
MIT License
861 stars 74 forks source link

Compatibility with pymdown-extensions >= 7.0 #58

Closed fsoubelet closed 4 years ago

fsoubelet commented 4 years ago

Hi,

The pymdown-extensions package has had a major release about two months ago. This 7.0 version adds quite a lot of nice things. Would it be possible to make portray compatible with this new version?

As I see it, they were on 6.0 when Portray was started, so running poetry add pymdown-extensions automatically gave the ^6.0 condition.

Hopefully changing this to ^7.0 would be enough. If not, I'd be glad to try and help. Similarly, it would be nice to try and have compatibility with mkdocs-material version 5.

fsoubelet commented 4 years ago

From a bit of playing around on my side, updating the dependencies for mkdocs-material and pymdown-extensions to respectively ^5.0 and ^7.0 seems fine.

It passes tests on Python 3.7, and works without issues in the few projects I've tried to use them in, making use of, for instance, pymdownx.tabbed (requires pymdown-extensions 7.0.0) or scheme = stale for material dark theme (requires mkdocs-material 5.2.0).

@timothycrosley would you be open to a PR on this?

timothycrosley commented 4 years ago

HI @fsoubelet, I'd be thrilled to accept a PR that resolved this!

Thanks!