timothycrosley / thedom

A python framework to generate html and JavaScript from reusable and combine-able widgets.
GNU General Public License v2.0
23 stars 6 forks source link

DataViews.Table generates invalid html with repeating values of id attributes #4

Open triquetra011 opened 11 years ago

triquetra011 commented 11 years ago

example: <tr> <td name="1" id="1"> ... </tr> <tr> <td name="1" id="1"> ...

Ids must be unique across the whole document. I would suggest setting ids by concatenating a unique table id with unique tr ids with unique th/td ids. It would be also good to let the user to switch ids off.

timothycrosley commented 11 years ago

Agreed! Going to make table autoIDs a property that must be explicitly checked to generate them, in which case the ID will be a combination of the tables id and the header id. This will be included in beta 3.

Thanks!