search

timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
120 stars 62 forks source link

Some housekeeping #141

Closed dfm closed 2 years ago

dfm commented 4 years ago

This is a "large" PR in terms of files touched, but it doesn't actually do very much. Here's what it does:

  1. Cleans up some formatting, imports, and syntax issues. This means that flake8 with various flags can be used to check the code. Right now there are a lot of except Exception clauses which is not awesome so we should probably audit that at some point to understand where we can be more specific.
  2. Migrates to GitHub Actions from Travis. This is a bit faster (partly because I precomputed some of the grids, although there is a test to make sure that the grid setup will work) and (I think) cleaner. But this is optional for sure.
  3. Pins maximum version numbers for numba and pandas. The pandas version is related to #138 and #139 but I'm just punting cause it's a real pain to figure out what is going wrong (possibly related to point 1 above). The numba version is related to the fact that "reflection" (whatever that is) is being deprecated.
dfm commented 4 years ago

cc @quadrychance

timothydmorton commented 3 years ago

Thanks for this @dfm; sorry for taking so long to look at it!