timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
120 stars 61 forks source link

Change triangle plot with the updated corner plot. #27

Closed DanielAndreasen closed 8 years ago

DanielAndreasen commented 8 years ago

Many of the changes are white spaces removed (my editor did that, sorry). The naming is kept, but I replaced the import and print if corner isn't installed. It is also changed in the setup file, setup.py. This will help with issue #26.

However, I get an error when I run the example from the notebook, but it doesn't seem to be related. Basically if distance is set to None (standard) at line 316 in starmodel.py, there is an error at line 365 in the same file.

timothydmorton commented 8 years ago

Hi thanks for this; I ended up fixing the triangle->corner issue myself. Thanks for pointing out the issue with the example notebook. That may be out of date. I'm working on a refactoring of the codebase now, so hopefully soon I'll have some new (and working) examples up there. Please do feel free to let me know if you have trouble with anything else.

DanielAndreasen commented 8 years ago

Great job! :)