search

timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
120 stars 62 forks source link

Minage/Maxage Initialization Fails for MIST But Works for Dartmouth #47

Closed kschlaufman closed 6 years ago

kschlaufman commented 7 years ago

I can initiate a grid of Dartmouth isochrones with a minimum age with no error:

dar = Dartmouth_Isochrone(minage=(10))

But if I try the same command with MIST isochrones

mist = MIST_Isochrone(minage=(10))

I get the following error:

TypeError Traceback (most recent call last)

in () ----> 1 mist = MIST_Isochrone(minage=(10)) TypeError: __init__() got an unexpected keyword argument 'minage'
timothydmorton commented 7 years ago

Sorry I haven't gotten around to checking this one out. It should be an easy fix, though; feel free to do it yourself and submit a PR...

timothydmorton commented 6 years ago

The minage keyword is now deprecated; you should use mod.set_bounds(age=(lo, hi)) on the StarModel object rather than setting this on the Isochrone object itself. I've now included a warning to this effect.