timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
120 stars 62 forks source link

Make StarModel compatible with stellar companions that may be detected in differing filters #51

Closed atw5179 closed 6 years ago

atw5179 commented 7 years ago

Currently, the following star.ini file is incompatible with StarModel because the companion stars were not all detected in the same filters.

maxAV = 0.162 RA = 287.69800 dec = 42.338718 Teff = 5465, 109 feh = 0.020, 0.150 logg = 4.449, 0.085

[twomass] J = 11.252, 0.021 H = 10.910, 0.019 K = 10.871, 0.013

[Lick] resolution = 0.5 separation_1 = 3.842 PA_1 = 53.056 H_1 = 4.343, 0.010000000000000231 K_1 = 4.105, 0.054999999999999716 separation_2 = 12.073 PA_2 = 256.378 H_2 = 7.488, 0.010000000000000231

Those companions that have detections in filters where others were not detected have useful color information that should be included, but currently cannot be. This would be a useful adjustment to the StarModel class.

timothydmorton commented 7 years ago

Just getting around to addressing outstanding issues here; this should now be fixed in the current master.

timothydmorton commented 7 years ago

Let me know if this works for you as needed.

timothydmorton commented 6 years ago

Closing this, as I now have a test using this star.ini file on current master. Please re-open if you find you still have issues with this.