timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
119 stars 63 forks source link

All stars have radius of 0.98 #52

Closed elisabethadams closed 7 years ago

elisabethadams commented 7 years ago

(Well, they probably don't actually.)

But the following instructions result in essentially the same values for Teff from 3000-7000:


mist = MIST_Isochrone()
model  = StarModel(mist, Teff=(5770, 80), logg=(4.44, 0.08), feh=(0.,0.1))
model.fit()
model.samples['radius_0_0'].quantile([0.15,0.5,0.85])

0.15    0.922251
0.50    0.982562
0.85    1.064326
timothydmorton commented 7 years ago

The secret of the universe has been discovered!

Two possible thoughts:

elisabethadams commented 7 years ago

Definitely running a new model.fit() every time (the numbers change after the 3rd decimal place every time I run it).

Changing logg (and increasing the errors) doesn't really affect it:


model  = StarModel(mist, Teff=(3000,200), logg=(4.7, 0.28), feh=(0.,0.1))

0.15    0.921389
0.50    0.981665
0.85    1.061877
timothydmorton commented 7 years ago

That's definitely not right...do the new fits take time to run? What if you call model.fit(refit=True)? You're using v1.0, right?

timothydmorton commented 7 years ago

(in other words I wonder whether the differences are just from choosing different random samples from the already-run multinest chains)

elisabethadams commented 7 years ago

Hmm, the refit=True may have done the trick! Why is refit=False the default?

timothydmorton commented 7 years ago

In my use, it's much more common for me to want to quickly pull up the results of an already-fit model than to change the parameters of a model and then refit. You can avoid this kind of problem by giving your StarModels names (use the name= keyword), because that will define what the multinest chains are called, and thus you won't have clashing fit files.

There is definitely an area that needs improvement! Thanks for bringing it to my attention.