search

timothydmorton / isochrones

Pythonic stellar model grid access; easy MCMC fitting of stellar properties
http://isochrones.readthedocs.org
MIT License
119 stars 63 forks source link

Check common columns with attribute #54

Closed smoh closed 6 years ago

smoh commented 6 years ago

Trying out examples in doc, I found that there's a redundant adding of common columns for MIST model because you check with 'MMo' whether common columns have been added, and it is not one of them for mist modelgrid: ('EEP', 'log10_isochrone_age_yr', 'initial_mass', 'log_Teff', 'log_g', 'log_L', 'Z_surf', 'feh', 'phase')

Also, I think scipy and numba is missing from requirements?

timothydmorton commented 6 years ago

Thanks! Yeah, that was a pretty sloppy check I had in there. I had added numba to the requirements at some point, but then that screwed someone up at some point, so I took it back out again.... I should probably see if I can conda-ify it to better handle dependencies.