timothygrant80 / cisTEM

Other
32 stars 27 forks source link

GUI chooses wrong movies for ctf estimation if movie_assets and image_assets are not aligned #445

Open jojoelfe opened 1 year ago

jojoelfe commented 1 year ago

This bug appears when initially movie alignment is performed on a subset of movies. In this case ctf estimation will use the wrong movies files if estimation using movies is selected. This is because the gui uses the image_asset array position to get the filename from the movie_assets array:

https://github.com/timothygrant80/cisTEM/blob/ef3dee68dc1348d0178c2773564eb55ef60b9399/src/gui/FindCTFPanel.cpp#L626-L629

This is done correctly later when the gain filename is retrieved:

https://github.com/timothygrant80/cisTEM/blob/ef3dee68dc1348d0178c2773564eb55ef60b9399/src/gui/FindCTFPanel.cpp#L665-L668

This probably hasn't come up yet, because most of the times all movies are aligned and then the array positions are in sync.

bHimes commented 8 months ago

fix this in PR #487