search

timothymiller / t4-app

A powerful cross-platform UI toolkit for building actually native iOS, Android, macOS, Windows, Linux, and Progressive Web Apps with React (Native).
https://t4stack.com
MIT License
1.45k stars 77 forks source link

Update to lucia v3, oslo, arctic #107

Closed rmarscher closed 10 months ago

rmarscher commented 10 months ago

I rebased on the latest master branch and squashed some commits. So probably best to do a hard-reset of your lucia-auth branch to this version rather than try to merge. I think after that, it's ready to go to master. I still don't personally have Apple, Google, Discord or GitHub OAuth client tokens, so most testing has been with the email/password flows. I might set up Google to have something to test with. I have tested email/password flows plus Google on iOS simulator and desktop Chrome and Safari as well as Sign in with Apple on iOS simulator.

See 51dbbe2 for the code around upgrading from lucia v2 to v3.

rmarscher commented 10 months ago

I'm setting up Google OAuth to test that flow... stand by...

Death666Machine commented 10 months ago

Very nice contribution, looking forward to seeing this merged into master 😊

hdwatts commented 10 months ago

Thanks for the huge legwork here, I've been able to implement your changes and things look to be working well. Noting that we are slightly blocked until the next beta of Lucia, as there is a necessary change to Lucia v3 for verifying the bearer token. (However it's easy enough to fix in your own local node_modules)

https://github.com/lucia-auth/lucia/pull/1258#discussion_r1390586988

rmarscher commented 10 months ago

Thanks for the huge legwork here, I've been able to implement your changes and things look to be working well. Noting that we are slightly blocked until the next beta of Lucia, as there is a necessary change to Lucia v3 for verifying the bearer token. (However it's easy enough to fix in your own local node_modules)

lucia-auth/lucia#1258 (comment)

Thanks a lot. I noticed those bugs when testing too. Sorry I didn't push those fixes already. I'm looking into an issue with getting the oauth state on native and hope to have that resolved soon. I assume a new lucia beta will get released on npm today. I saw your fix was merged.

hdwatts commented 10 months ago

Thanks for the huge legwork here, I've been able to implement your changes and things look to be working well. Noting that we are slightly blocked until the next beta of Lucia, as there is a necessary change to Lucia v3 for verifying the bearer token. (However it's easy enough to fix in your own local node_modules)

lucia-auth/lucia#1258 (comment)

Thanks a lot. I noticed those bugs when testing too. Sorry I didn't push those fixes already. I'm looking into an issue with getting the oauth state on native and hope to have that resolved soon. I assume a new lucia beta will get released on npm today. I saw your fix was merged.

Of course my friend, thanks for doing the vast vast majority of the work! Let me know if I can assist further :)

hdwatts commented 10 months ago

Again I cannot thank you enough for this Herculean effort you've made here. The code is easy to follow and reason with even for an auth layperson like myself. I've implemented your updates on my local branch and things are working smoothly!

I'll give it another pass through tomorrow but for now...bed!

timothymiller commented 10 months ago

The lucia-auth branch is now called lucia

rmarscher commented 10 months ago

I switched the PR to point to lucia and addressed the items that @hdwatts noted. :+1:

timothymiller commented 10 months ago

I'm going to merge it in. We can submit further PRs to address any remaining issues.

LGTM ship it!!