search

timothymiller / t4-app

A powerful cross-platform UI toolkit for building actually native iOS, Android, macOS, Windows, Linux, and Progressive Web Apps with React (Native).
https://t4stack.com
MIT License
1.34k stars 71 forks source link

Fix for shorthands #40

Closed xerxiastudios closed 1 year ago

timothymiller commented 1 year ago

This does not work for me.

Steps to reproduce:

This type error is shown

Screenshot 2023-07-28 at 13 45 02
timothymiller commented 1 year ago

I don't think this is right. The return type of createTamagui is TamaguiInternalConfig.

The prop types of the function are CreateTamaguiProps

Screenshot 2023-07-28 at 13 52 29
timothymiller commented 1 year ago

The issue was that "latest" was not in fact pulling the latest version. I changed it to specify the latest version number, and now the typescript issue is gone.

xerxiastudios commented 1 year ago

Yeah my bad for giving the props as type, but the type safety kicks in only in the full repo, if I check in the starter with cli then we can safely remove the type.