timothymiller / t4-app

A powerful cross-platform UI toolkit for building actually native iOS, Android, macOS, Windows, Linux, and Progressive Web Apps with React (Native).
https://t4stack.com
MIT License
1.31k stars 70 forks source link

Update virtualized list demo #69

Closed rmarscher closed 10 months ago

rmarscher commented 10 months ago

I also updated the database table names to lowercase plural to match the naming in the seed file. If you prefer, I could resubmit with keeping the table names and just updating the seed file.

Feel free to close if you want to go in a different direction. No worries. Thanks for all of the work on this project so far!

timothymiller commented 10 months ago

What's the proper casing of an SQL table?

I like Car, so the type inteferencing looks correct Car[] vs Cars[]

Is the first letter capitalized or is it all lower case?

rmarscher commented 10 months ago

I think it's subjective. Let me resubmit this preserving that naming. :)

rmarscher commented 10 months ago

OK @timothymiller. I reversed the table naming change and just corrected the table name in the seed file. Ready for review. The way this is solution calls the onScroll prop in the web version is a hack... but it works for tracking scroll position which I think is the main use case.