Closed tonyabracadabra closed 6 months ago
It is really weird, @timothymiller the pressStyle with the latest version of tamagui isn’t working in t4 but works with the official starter template @natew Maybe there is some problem with the babel plugin or other version incompatibilities I’m not sure
Maybe because react-native-web-lite
, you need to update that version alongside tamagui. Actually I think removing react-native-web-lite in general is fine, I'm slowly going to deprecate it and move all our starters off it.
@timothymiller Hey
Maybe because
react-native-web-lite
, you need to update that version alongside tamagui. Actually I think removing react-native-web-lite in general is fine, I'm slowly going to deprecate it and move all our starters off it.
interesting, why would react-native-web-lit
effect the pressStyle in ios?
I tried using the latest tamagui upgrade command in the repo that upgrades the react-native-web-lit
as well (pnpm up -r '*tamagui*'@latest '@tamagui/*'@latest react-native-web-lite@latest
), but the problem persists
Actually, not only does the pressStyle
is missing, the theme (I enabled the default theme as dark) is also broken for me in IOS simulator using the configuration in t4, could you help reproduce the issue? @timothymiller @natew
Below is the style comparison on web/ios simulator
Hi @tonyabracadabra try to remove the dotenv
from babel.config.
in my case removing those from babel config make the pressStyle
working again
I'll get a proper fix this weekend, but this is the temporary fix.
Thanks @natew for investigating this. FWIW, I was not able to get light theme button presses to work, even with removing dotenv support. Anyway, we need this for setting the API url ,etc.
About to sign off for the night. Will investigate more tomorrow!
The latest versions should fix this I believe, I made them de-opt on all press styles for native optimization.
Small snippet to repro?
1.75.9
to 1.76.0
and the iOS press styles were still missing1.76.0
introduced a weird issue when starting the next.js project:bun create t4-app
followed by
bun i
bun ios
Should display the press style bug in it's full glory
I'm sure the issue is something incorrectly set in the tamagui theme config. This issue exists in the tamagui starter repo as well. Will investigate more later this week.
- I upgraded all Tamagui versions from
1.75.9
to1.76.0
and the iOS press styles were still missing- dotenv is now removed from the expo project in favor of Expo 49 environment variable support
1.76.0
introduced a weird issue when starting the next.js project:![]()
To reproduce this,
bun create t4-app
followed by
bun i bun ios
Should display the press style bug in it's full glory
@natew Could you assist reproducing the issue?
I fixed the issue in the reproduction that was opened on Tamagui by fixing stuff in static, and then just went and tested the starter and it works on inline and styled() usages:
https://github.com/timothymiller/t4-app/assets/12100/f25f028b-9ccc-4217-9d1c-bd9402bce527
https://github.com/timothymiller/t4-app/assets/12100/05223f4f-84ea-4318-ae1e-00d782ac434c
Can't replicate there at least.
Can someone test if this is fixed with the latest Tamagui 1.79? It's already in the master branch
It's working properly. It's just super faint in light mode
I was not able to configure any
pressStyles
in tamagui, for example the code from https://tamagui.dev/docs/core/animations#react-native-animatedThe following
isn't working for me when I click and hold on the IOS simulator, but it works perfectly in web.