Checkroth commented 4 years ago

Description

Adds support for FIFO queues to SQSClientExtended. Includes some slight refactoring to avoid implementing the same logic multiple times.

Fixes #11

PR type

[x] Feature
[ ] TechDebt
[ ] Bugfix
[ ] Other

Changelog updated

[ ] Yes
[x] No

There are no current changelog entries, so I am unsure of the format.

Breaking changes

[ ] Yes
[x] No

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Pushed to a FIFO queue with message group and deduplication IDs, and it worked
[x] Pushed to a FIFO queue without message group and deduplication IDs, and it failed (expected)
[x] Pushed to a standard queue with message group and deduplication IDs and it worked
[x] Pushed to a standard queue without message group and deduplication IDs and it worked.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules
[ ] PR has been appropriately with a meaning tag
- There are no current tags, so I can't add one.

codecov-io commented 4 years ago

Codecov Report

Merging #12 into master will decrease coverage by 1.14%. The diff coverage is 21.05%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   25.30%   24.15%   -1.15%     
==========================================
  Files           3        3              
  Lines         166      178      +12     
==========================================
+ Hits           42       43       +1     
- Misses        124      135      +11

Impacted Files	Coverage Δ
pysqs_extended_client/SQSClientExtended.py	`21.05% <21.05%> (-0.96%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17d7a24...471c684. Read the comment docs.