timothymugayi / boto3-sqs-extended-client-lib

Boto3 SQS Extended Client Library for Python. An extension to the boto3 sqs client that enables sending and receiving messages up to 2GB via Amazon S3. [WARNING: This library is still under development contributors welcome]
Apache License 2.0
27 stars 23 forks source link

Incompatible message format compared to amazon-sqs-java-extended-client-lib #7

Closed bvinayakumar closed 3 years ago

bvinayakumar commented 5 years ago

The message format produced by "boto3-sqs-extended-client-lib" and "amazon-sqs-java-extended-client-lib" are different if the message size is greater than 256 KB.

boto3-sqs-extended-client-lib (JSON object)

e.g. {"s3BucketName":"some-bucket","s3Key":"some-uuid"}

amazon-sqs-java-extended-client-lib (JSON array)

e.g. ["com.amazon.sqs.javamessaging.MessageS3Pointer",{"s3BucketName":"some-bucket","s3Key":"some-uuid"}]

The purpose of raising this issue is to align the message format with Amazon SQS Extended Client Library for Java mentioned in the official documentation.

References: https://docs.amazonaws.cn/en_us/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-s3-messages.html https://github.com/awslabs/amazon-sqs-java-extended-client-lib

timothymugayi commented 4 years ago

@bvinayakumar thanks for the catch will look into it.

Izbitzer commented 3 years ago

I created a PR for this, apologies if anything is missing. I'd be happy to add anything else that would be needed to get it merged.