timothywongej / pe

0 stars 0 forks source link

Duplicate student instance for 'add' command #1

Open timothywongej opened 2 years ago

timothywongej commented 2 years ago

A duplicate person can be added to the contact list with an extra white space.

E.g. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/ALevels nok/ n/Mary Doe p/93334848 e/mary23@gmail.com a/311, Clementi Ave 2, #02-25 adds a person named John Doe to the address book.

And the following command, where there is a white space between the first name and surname, also adds a new person. add n/john doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 t/ALevels nok/ n/Mary Doe p/93334848 e/mary23@gmail.com a/311, Clementi Ave 2, #02-25

This can be seen in the following screenshot:

Screenshot 2021-11-12 at 4.21.22 PM.png

Perhaps a warning could be added to this style check in the parser.

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to enter 2 person with the same name if there are two whitespaces

Steps to reproduce: (used A to represent whitespace because I was unable to type 2 whitespaces consecutively)

  1. add command to add person named JohnADoe: add n/JohnADoe p/....
  2. add command to add person named JohnAADoe: add n/JohnAADoe p/....

Expected:

warning or error saying duplicate names

Actual:

able to add another person of same name image.png


[original: nus-cs2103-AY2122S1/pe-interim#5082] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: I believe this constitutes as a bug of low severity because it is not a "purely cosmetic (e.g typo, spacing, layout, colour, font) flaw that doesn't affect usage."

Screenshot 2021-11-17 at 10.53.10 PM.png