timothywongej / pe

0 stars 0 forks source link

NFR number 14 should be edited in DG #12

Open timothywongej opened 2 years ago

timothywongej commented 2 years ago

Non-functional requirement no.14 states Should package everything into a single JAR file. However, the application runs using a separate data folder and other .json files. Perhaps adding this into the NFR would be clearer for future developers.

nus-pe-bot commented 2 years ago

Team's Response

The reviewer is mistaken. Packaging into a single jar file means that the app itself is packaged into a single jar file for download. For example, when we do a release, we are releasing a single jar file. That is the "single jar file" that we have packaged into. The other files are necessary to store data and preferences for the current users. That is also why we are asked to put the jar file into a new folder before we run it.

As the screenshot from the module website below implies: The "single jar file" means that when users download our app, it should only through downloading a single jar file: (Hence the reviewer is totally mistaken)

Screenshot 2021-11-14 at 12.20.21 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]