Closed timothyyu closed 5 years ago
the scale_periods() function should not be in wsae_lstm/models/wavelet.py; it should be under wsae_lstm/features/scale_dataset.py .
scale_periods()
wsae_lstm/models/wavelet.py
wsae_lstm/features/scale_dataset.py
The same applies to the denoise_periods() function - it shouldn't be under wavelet.py.
denoise_periods()
wavelet.py
https://github.com/timothyyu/wsae-lstm/blob/master/wsae_lstm/models/wavelet.py#L46
def scale_periods(dict_dataframes): ddi_scaled = dict() for key, index_name in enumerate(dict_dataframes): ddi_scaled[index_name] = copy.deepcopy(dict_dataframes[index_name]) for key, index_name in enumerate(ddi_scaled): scaler = preprocessing.RobustScaler(with_centering=True) for index,value in enumerate(ddi_scaled[index_name]): X_train = ddi_scaled[index_name][value][1] X_train_scaled = scaler.fit_transform(X_train) X_train_scaled_df = pd.DataFrame(X_train_scaled,columns=list(X_train.columns)) X_val = ddi_scaled[index_name][value][2] X_val_scaled = scaler.transform(X_val) X_val_scaled_df = pd.DataFrame(X_val_scaled,columns=list(X_val.columns)) X_test = ddi_scaled[index_name][value][3] X_test_scaled = scaler.transform(X_test) X_test_scaled_df = pd.DataFrame(X_test_scaled,columns=list(X_test.columns)) ddi_scaled[index_name][value][1] = X_train_scaled_df ddi_scaled[index_name][value][2] = X_val_scaled_df ddi_scaled[index_name][value][3] = X_test_scaled_df return ddi_scaled```
fixed in https://github.com/timothyyu/wsae-lstm/commit/9c796bf4e46558e5e7e5526dfec9763a286b74a4, moved into scale.py, denoise.py & build_features.py
scale.py
denoise.py
build_features.py
the
scale_periods()
function should not be inwsae_lstm/models/wavelet.py
; it should be underwsae_lstm/features/scale_dataset.py
.The same applies to the
denoise_periods()
function - it shouldn't be underwavelet.py
.https://github.com/timothyyu/wsae-lstm/blob/master/wsae_lstm/models/wavelet.py#L46